Add Cray compiler's equivalent of -Werror before __attribute__ checks

Cray uses -herror_on_warning instead of -Werror. Use it everywhere -Werror is
currently used for __attribute__ checks so configure actually detects they're
not supported.